Messages in this thread Patch in this message | | | Date | Thu, 30 May 2013 14:25:10 +0800 | From | Chen Gang <> | Subject | [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero. |
| |
'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original author wanted to check the highest bit whether set.
So need type cast form 'unsigned long' to 'long'.
The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig) arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/m68k/math-emu/fp_arith.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c index 08f286d..ef013c5 100644 --- a/arch/m68k/math-emu/fp_arith.c +++ b/arch/m68k/math-emu/fp_arith.c @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode) return; break; case 0x401e: - if (!(oldmant.m32[1] >= 0)) + if (!((long)oldmant.m32[1] >= 0)) return; if (oldmant.m32[0] & 1) break; -- 1.7.7.6
| |