Messages in this thread | | | Date | Tue, 28 May 2013 14:07:12 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas. |
| |
On 05/24/2013 09:18 AM, Chen Gang wrote: > On 05/24/2013 01:28 AM, Anton Vorontsov wrote: >> > On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: >>>> >> > Delete waste '{' for 'case' statement. >>>> >> > >>>> >> > For the return variable 'long res' in function kdb_task_state_string(), >>>> >> > neither it matches the function return type 'unsigned long', nor is >>>> >> > suitable as a flag variable to make 'or' operation. So use 'unsigned >>>> >> > long' instead of 'long'. >>>> >> > >>>> >> > If "case 'A'" happen in function kdb_task_state_string(), can return >>>> >> > ~0UL directly to save the useless looping. >>>> >> > >>>> >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> >> > If anything, these should be 3 separate patches... >> >
My original 3 fix issues old patches for "kernel/debug" are still non-reply, then the new minor cleanup patches (if I will provide the 3 patches) will of cause be none-reply, too.
Now, I am not a newbie anymore, so I can/should understand it, at least, it should not stop me to continue providing patches to another members.
And thank you for your encouraging.
:-)
> OK, I will separate them into 3 patches (originally, I think for trivial > cleanup patches, better let them in one patch, so can save the reviewers > and appliers time) > > Excuse me, I have to do something else, so I will finish them within > this month (2013-05-31) > > > Thanks. > -- Chen Gang Asianux Corporation
-- Chen Gang
Asianux Corporation
| |