Messages in this thread | | | Date | Fri, 24 May 2013 09:18:10 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas. |
| |
On 05/24/2013 01:28 AM, Anton Vorontsov wrote: > On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: >> > Delete waste '{' for 'case' statement. >> > >> > For the return variable 'long res' in function kdb_task_state_string(), >> > neither it matches the function return type 'unsigned long', nor is >> > suitable as a flag variable to make 'or' operation. So use 'unsigned >> > long' instead of 'long'. >> > >> > If "case 'A'" happen in function kdb_task_state_string(), can return >> > ~0UL directly to save the useless looping. >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > If anything, these should be 3 separate patches... >
OK, I will separate them into 3 patches (originally, I think for trivial cleanup patches, better let them in one patch, so can save the reviewers and appliers time)
Excuse me, I have to do something else, so I will finish them within this month (2013-05-31)
Thanks. -- Chen Gang
Asianux Corporation
| |