Messages in this thread Patch in this message | | | Date | Sun, 26 May 2013 16:50:22 +0800 | From | Chen Gang <> | Subject | [PATCH] arch: x86: platform: mrst: pr_err() need notice that 'sdev->modalias' may not a NUL terminated string. |
| |
According to the areas which use "%16.16s" within this file, the 'sdev->modalias' may not always be a NUL terminated string.
So need use "%.16s" instead of "%s" in pr_err(), or may cause issue.
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/x86/platform/mrst/mrst.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c index a0a0a43..e2e069c 100644 --- a/arch/x86/platform/mrst/mrst.c +++ b/arch/x86/platform/mrst/mrst.c @@ -746,7 +746,7 @@ static void __init intel_scu_spi_device_register(struct spi_board_info *sdev) new_dev = kzalloc(sizeof(*sdev), GFP_KERNEL); if (!new_dev) { - pr_err("failed to alloc mem for delayed spi dev %s\n", + pr_err("failed to alloc mem for delayed spi dev %.16s\n", sdev->modalias); return; } -- 1.7.7.6
| |