Messages in this thread | | | Date | Thu, 23 May 2013 11:01:28 -0500 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts |
| |
On Thu, May 23, 2013 at 09:42:37AM -0600, Stephen Warren wrote:
> I guess the core of the issue is that you want to replace spin_lock() > with spin_lock_irqsave(). I'd like to see that explicitly described in > the commit description, if that is the core aspect of this change.
Yes, I was just going to rewrite the commit log to make this a lot clearer - the entire first paragraph could pretty much just be replaced by just saying that we need spin_lock_irqsave() to allow interaction with interrupt context.
> ... and obviously add a spinlock_flags field to struct regmap (perhaps > start unioning the mutex and spinlock data fields there if you want to > save space).
This should work, yes - care to respin Lars-Peter? [unhandled content-type:application/pgp-signature] | |