Messages in this thread | | | Date | Thu, 23 May 2013 09:05:03 -0500 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts |
| |
On Thu, May 23, 2013 at 03:06:16PM +0200, Lars-Peter Clausen wrote:
> This patch updates the adds a flags parameter to the regmap lock and unlock > callbacks and uses spin_lock_irqsave() and spin_unlock_restore() for the mmio > case. This allows us to use regmap-mmio from different contexts.
This seems really invasive, why not just have the lock that gets passed in point to a struct which has both the lock and the flags? As far as the core is concerned the lock is just whatever data is required to do the locking, the fact that it's actually two values is an implementation detail of this locking implementation. [unhandled content-type:application/pgp-signature] | |