Messages in this thread | | | Subject | Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling | From | Joe Perches <> | Date | Mon, 20 May 2013 01:29:47 -0700 |
| |
On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: > From: Eliezer Tamir <eliezer.tamir@linux.intel.com> [] > > { > > struct socket *sock; > > + unsigned int poll_result; > > Please order local variable declarations from longest line to > shortest line.
reverse christmas tree doesn't seem especially valuable or sensible for automatics.
I'd rather order by first use or even alphabetical, especially with long lists of automatics.
| |