Messages in this thread | | | Date | Mon, 20 May 2013 12:39:59 +0300 | From | Eliezer Tamir <> | Subject | Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling |
| |
On 20/05/2013 10:54, David Miller wrote: > From: Eliezer Tamir <eliezer.tamir@linux.intel.com> > Date: Sun, 19 May 2013 13:25:33 +0300 > >> +#else /* CONFIG_INET_LL_RX_FLUSH */ >> + >> +#define sk_valid_ll(sk) 0 >> +#define sk_poll_ll(sk, nonblock) do {} while (0) >> +#define skb_mark_ll(napi, skb) do {} while (0) >> +#define sk_mark_ll(sk, skb) do {} while (0) > > Make these inline functions too, so that even if > CONFIG_INET_LL_RX_POLL is disabled, the arguments and return values > are still properly type checked.
Is this what you had in mind?
static inline bool sk_valid_ll(struct sock *sk) { return 0; }
static inline bool sk_poll_ll(struct sock *sk, int noblock) { return 0; }
static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct *napi) { }
static inline voiv sk_mark_ll(struct sock *sk, struct sk_buff *skb) { }
would you like me to resend the whole set or just this patch?
Thanks, Eliezer
| |