Messages in this thread Patch in this message | | | From | Lars-Peter Clausen <> | Subject | [PATCH] unicore: dma: Pass correct pointer to free_irq() | Date | Mon, 20 May 2013 19:11:26 +0200 |
| |
free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl> @r1@ type T; T devid; @@ request_irq(..., devid)
@r2@ type r1.T; T devid; position p; @@ free_irq@p(..., devid)
@@ position p != r2.p; @@ *free_irq@p(...) </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- arch/unicore32/kernel/dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/unicore32/kernel/dma.c b/arch/unicore32/kernel/dma.c index ed2d4d7..07f1b06 100644 --- a/arch/unicore32/kernel/dma.c +++ b/arch/unicore32/kernel/dma.c @@ -172,7 +172,7 @@ int __init puv3_init_dma(void) ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL); if (ret) { printk(KERN_CRIT "Can't register IRQ for DMAERR\n"); - free_irq(IRQ_DMA, "DMA"); + free_irq(IRQ_DMA, NULL); return ret; } -- 1.8.0
| |