Messages in this thread Patch in this message | | | From | Lars-Peter Clausen <> | Subject | [PATCH] spi: topcliff-pch: Pass correct pointer to free_irq() | Date | Mon, 20 May 2013 17:54:35 +0200 |
| |
free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl> @r1@ type T; T devid; @@ request_irq(..., devid)
@r2@ type r1.T; T devid; position p; @@ free_irq@p(..., devid)
@@ position p != r2.p; @@ *free_irq@p(...) </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- drivers/spi/spi-topcliff-pch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index 35f60bd..963e0f3 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -1487,7 +1487,7 @@ static int pch_spi_pd_probe(struct platform_device *plat_dev) return 0; err_spi_register_master: - free_irq(board_dat->pdev->irq, board_dat); + free_irq(board_dat->pdev->irq, data); err_request_irq: pch_spi_free_resources(board_dat, data); err_spi_get_resources: -- 1.8.0
| |