Messages in this thread Patch in this message | | | Date | Thu, 2 May 2013 19:39:50 +0800 | From | Libo Chen <> | Subject | [PATCH] tpm_tis: fix missing platform_driver_unregister |
| |
Add missing unregister tis_drv after register pdev fail
Signed-off-by: Libo Chen <libo.chen@huawei.com> --- drivers/char/tpm/tpm_tis.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 8a41b6b..d5b0af4 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -884,8 +884,11 @@ static int __init init_tis(void) rc = platform_driver_register(&tis_drv); if (rc < 0) return rc; - if (IS_ERR(pdev=platform_device_register_simple("tpm_tis", -1, NULL, 0))) - return PTR_ERR(pdev); + pdev = platform_device_register_simple("tpm_tis", -1, NULL, 0); + if (IS_ERR(pdev) { + platform_driver_unregister(&tis_drv); + return PTR_ERR(pdev); + } if((rc=tpm_tis_init(&pdev->dev, TIS_MEM_BASE, TIS_MEM_LEN, 0)) != 0) { platform_device_unregister(pdev); platform_driver_unregister(&tis_drv); -- 1.7.1
| |