Messages in this thread Patch in this message | | | Date | Sun, 19 May 2013 15:59:50 +0300 | From | Dan Carpenter <> | Subject | [patch] gru: fix a sanity test in gru_set_context_option() |
| |
"req.val1 == -1" is valid but it doesn't make sense to check gru_base[-1]. gru_base[] is a global array.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c index c4acac7..e7c37b2 100644 --- a/drivers/misc/sgi-gru/grufault.c +++ b/drivers/misc/sgi-gru/grufault.c @@ -876,7 +876,8 @@ int gru_set_context_option(unsigned long arg) switch (req.op) { case sco_blade_chiplet: /* Select blade/chiplet for GRU context */ - if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] || + if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || + (req.val1 != -1 && !gru_base[req.val1]) || req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) { ret = -EINVAL; } else {
| |