Messages in this thread | | | Date | Thu, 16 May 2013 08:29:23 -0400 | From | Eduardo Valentin <> | Subject | Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices |
| |
On 15-05-2013 12:57, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:36 Wed 15 May , Eduardo Valentin wrote: >> On 15-05-2013 11:23, Benoit Cousson wrote: >>> Hi Eduardo, >>> >>> On 05/15/2013 04:58 PM, Eduardo Valentin wrote: >>>> Include bandgap devices for OMAP4460 devices. >>>> >>>> Cc: "Benoît Cousson" <b-cousson@ti.com> >>>> Cc: Tony Lindgren <tony@atomide.com> >>>> Cc: Russell King <linux@arm.linux.org.uk> >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >>>> --- >>>> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi >>>> index 2cf227c..e5bfbfe 100644 >>>> --- a/arch/arm/boot/dts/omap4460.dtsi >>>> +++ b/arch/arm/boot/dts/omap4460.dtsi >>>> @@ -29,4 +29,13 @@ >>>> <0 55 0x4>; >>>> ti,hwmods = "debugss"; >>>> }; >>>> + >>>> + bandgap { >>>> + reg = <0x4a002260 0x4 >>>> + 0x4a00232C 0x4 >>>> + 0x4a002378 0x18>; >>>> + compatible = "ti,omap4460-bandgap"; >>>> + interrupts = <0 126 4>; /* talert */ >>>> + ti,tshut-gpio = <86>; >> >> >> >>> >>> Why do you need a custom attribute for GPIO? Cannot you use the standard >>> one? >> >> I believe it was by your suggestion :-), during the first attempts to >> send this driver. But could not find the thread link :-( sorry. >> >> >> I guess the reasoning to mark it as a ti specific is because it will be >> used as IRQ line to treat thermal shutdown (in SW). > so use interrup-parent
Jean-Christophe,
That will change the controller and break the configuration for the other IRQ line, coming from GIC.
>> >>> >>> Where is the gpio controller phandle? >>> >>> Usually it looks like this: >>> >>> gpios = <&gpio1 8 0>; >>> >>> >>> Regards, >>> Benoit >>> >>> >>> >> >> > > > >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > >
[unhandled content-type:application/pgp-signature] | |