Messages in this thread | | | Date | Wed, 15 May 2013 17:23:33 +0200 | From | Benoit Cousson <> | Subject | Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices |
| |
Hi Eduardo,
On 05/15/2013 04:58 PM, Eduardo Valentin wrote: > Include bandgap devices for OMAP4460 devices. > > Cc: "Benoît Cousson" <b-cousson@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: linux-omap@vger.kernel.org > Cc: devicetree-discuss@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi > index 2cf227c..e5bfbfe 100644 > --- a/arch/arm/boot/dts/omap4460.dtsi > +++ b/arch/arm/boot/dts/omap4460.dtsi > @@ -29,4 +29,13 @@ > <0 55 0x4>; > ti,hwmods = "debugss"; > }; > + > + bandgap { > + reg = <0x4a002260 0x4 > + 0x4a00232C 0x4 > + 0x4a002378 0x18>; > + compatible = "ti,omap4460-bandgap"; > + interrupts = <0 126 4>; /* talert */ > + ti,tshut-gpio = <86>;
Why do you need a custom attribute for GPIO? Cannot you use the standard one?
Where is the gpio controller phandle?
Usually it looks like this:
gpios = <&gpio1 8 0>;
Regards, Benoit
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |