Messages in this thread | | | Date | Fri, 10 May 2013 21:58:01 +0800 | From | Alex Shi <> | Subject | Re: [PATCH v5 6/7] sched: consider runnable load average in move_tasks |
| |
On 05/09/2013 09:24 AM, Alex Shi wrote: > Paul, > > I am wondering if the following patch needed. > The wakeuped migrated task will __synchronize_entity_decay(se); in migrate_task_fair, > then it needs to set `se->avg.last_runnable_update -= (-se->avg.decay_count) << 20' > before update_entity_load_avg, in order to avoid slept time is updated twice for > se.avg.load_avg_contrib in both __syncchronize and update_entity_load_avg. > > but if the slept task is waked up from self cpu, it miss the last_runnable_update before > update_entity_load_avg(se, 0, 1), so the slept time was used twice in both functions. > Is that right?
Would you like to give some comments on this, Paul?
-- Thanks Alex
| |