Messages in this thread | | | From | KOSAKI Motohiro <> | Date | Tue, 9 Apr 2013 21:53:55 -0400 | Subject | Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page() |
| |
> I rewrite the comment here, how about this? > > - if (absent || > + /* > + * We need call hugetlb_fault for both hugepages under migration > + * (in which case hugetlb_fault waits for the migration,) and > + * hwpoisoned hugepages (in which case we need to prevent the > + * caller from accessing to them.) In order to do this, we use > + * here is_swap_pte instead of is_hugetlb_entry_migration and > + * is_hugetlb_entry_hwpoisoned. This is because it simply covers > + * both cases, and because we can't follow correct pages directly > + * from any kind of swap entries. > + */ > + if (absent || is_swap_pte(huge_ptep_get(pte)) || > ((flags & FOLL_WRITE) && !pte_write(huge_ptep_get(pte)))) { > int ret;
Looks ok to me.
| |