lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()
> I rewrite the comment here, how about this?
>
> - if (absent ||
> + /*
> + * We need call hugetlb_fault for both hugepages under migration
> + * (in which case hugetlb_fault waits for the migration,) and
> + * hwpoisoned hugepages (in which case we need to prevent the
> + * caller from accessing to them.) In order to do this, we use
> + * here is_swap_pte instead of is_hugetlb_entry_migration and
> + * is_hugetlb_entry_hwpoisoned. This is because it simply covers
> + * both cases, and because we can't follow correct pages directly
> + * from any kind of swap entries.
> + */
> + if (absent || is_swap_pte(huge_ptep_get(pte)) ||
> ((flags & FOLL_WRITE) && !pte_write(huge_ptep_get(pte)))) {
> int ret;

Looks ok to me.


\
 
 \ /
  Last update: 2013-04-10 04:21    [W:1.271 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site