Messages in this thread | | | From | KOSAKI Motohiro <> | Date | Mon, 8 Apr 2013 16:57:44 -0400 | Subject | Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page() |
| |
> - if (absent || > + /* > + * is_swap_pte test covers both is_hugetlb_entry_hwpoisoned > + * and hugepages under migration in which case > + * hugetlb_fault waits for the migration and bails out > + * properly for HWPosined pages. > + */ > + if (absent || is_swap_pte(huge_ptep_get(pte)) || > ((flags & FOLL_WRITE) && !pte_write(huge_ptep_get(pte)))) { > int ret;
Your comment describe what the code is. However we want the comment describe why. In migration case, calling hugetlb_fault() is natural. but in hwpoison case, it is needed more explanation. Why can't we call is_hugetlb_hwpoisoned() directly?
| |