Messages in this thread | | | Date | Tue, 9 Apr 2013 17:17:46 -0700 | Subject | Re: [PATCH v2 2/7] staging: android: binder: replace IOCTL types with user-exportable types | From | Arve Hjønnevåg <> |
| |
On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu <serban.constantinescu@arm.com> wrote: > This patch modifies the IOCTL macros to use user-exportable data types, > as they are the referred kernel types for the user/kernel interface. > > The patch does not change in any way the functionality of the binder driver. > > Signed-off-by: Serban Constantinescu <serban.constantinescu@arm.com>
Acked-by: Arve Hjønnevåg <arve@android.com>
> --- > drivers/staging/android/binder.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h > index f240464..dbe81ce 100644 > --- a/drivers/staging/android/binder.h > +++ b/drivers/staging/android/binder.h > @@ -85,11 +85,11 @@ struct binder_version { > #define BINDER_CURRENT_PROTOCOL_VERSION 7 > > #define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read) > -#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, int64_t) > +#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64) > #define BINDER_SET_MAX_THREADS _IOW('b', 5, size_t) > -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, int) > -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, int) > -#define BINDER_THREAD_EXIT _IOW('b', 8, int) > +#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32) > +#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32) > +#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
BINDER_SET_CONTEXT_MGR and BINDER_THREAD_EXIT don't actually take an argument.
> #define BINDER_VERSION _IOWR('b', 9, struct binder_version) > > /* > -- > 1.7.9.5 >
-- Arve Hjønnevåg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |