Messages in this thread | | | Date | Tue, 9 Apr 2013 16:55:35 -0700 | Subject | Re: [PATCH v2 5/7] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration | From | Arve Hjønnevåg <> |
| |
On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu <serban.constantinescu@arm.com> wrote: > BinderDriverCommands mirror the ioctl usage. Thus the size of the > structure passed through the interface should be used to generate the > ioctl No. > > The change reflects the type being passed from the user space-a pointer > to a binder_buffer. This change should not affect the existing 32bit > user space since BC_FREE_BUFFER is computed as: > > #define _IOW(type,nr,size) \ > ((type) << _IOC_TYPESHIFT) | \ > ((nr) << _IOC_NRSHIFT) | \ > ((size) << _IOC_SIZESHIFT)) > > and for a 32bit compiler BC_FREE_BUFFER will have the same computed > value. This change will also ease our work in differentiating > BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. > > The change does not affect existing 32bit ABI. > > Signed-off-by: Serban Constantinescu <serban.constantinescu@arm.com>
Acked-by: Arve Hjønnevåg <arve@android.com>
-- Arve Hjønnevåg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |