Messages in this thread | | | Date | Tue, 09 Apr 2013 13:20:53 -0600 | From | Khalid Aziz <> | Subject | Re: [PATCH] x86, mce: Print warning if MCE handler fails to register /dev/mcelog |
| |
On 04/09/2013 12:30 PM, Luck, Tony wrote: > - misc_register(&mce_chrdev_device); > + if (misc_register(&mce_chrdev_device) != 0) > + pr_warn("Failed to register mcelog device\n"); > > Did this actually happen to you? Or is this just "good practice" to check the > return value from misc_register? >
No, I did not see this happen. It is just "good practice". If it were to happen, mcelog daemon would fail to get any mce records and it will not be easy to figure out what happened. Most other places in kernel where misc_register() is called, do check for return code and take action if it fails.
-- Khalid
| |