lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86, mce: Print warning if MCE handler fails to register /dev/mcelog
Date
-	misc_register(&mce_chrdev_device);
+ if (misc_register(&mce_chrdev_device) != 0)
+ pr_warn("Failed to register mcelog device\n");

Did this actually happen to you? Or is this just "good practice" to check the
return value from misc_register?

If this can really happen, we should remember that it failed and
just drop out of mce_log() early (no point in queueing up records
when there is no way for a user to ever access them).

-Tony
\
 
 \ /
  Last update: 2013-04-09 21:21    [W:0.052 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site