Messages in this thread | | | Subject | Re: [PATCH v3 1/1] Introduce Intel RAPL cooling device driver | From | Joe Perches <> | Date | Tue, 09 Apr 2013 09:29:48 -0700 |
| |
On Tue, 2013-04-09 at 09:07 -0700, Greg Kroah-Hartman wrote: > On Tue, Apr 09, 2013 at 08:53:37AM -0700, Joe Perches wrote: > > On Tue, 2013-04-09 at 08:26 -0700, Greg Kroah-Hartman wrote: > > > On Tue, Apr 09, 2013 at 05:46:18AM -0700, Jacob Pan wrote: > > > > +#define DEBUG > > > Why? I think you need to remove this line :) > > > > Some people like their dev_dbg statements to > > be emitted all the time. > > Those people should not be submitting new drivers for inclusion in the > kernel tree.
I think age of code (with some obvious exceptions) isn't too much of a reliable indicator and adding new CONFIG_<foo>_DEBUG controls isn't all that great a way to enable debugging.
| |