Messages in this thread | | | Date | Tue, 9 Apr 2013 09:15:17 -0700 | From | Jacob Pan <> | Subject | Re: [PATCH v3 1/1] Introduce Intel RAPL cooling device driver |
| |
On Tue, 9 Apr 2013 08:26:38 -0700 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > + if (NULL == rp->name || rp->flag & RAPL_PRIMITIVE_DUMMY) > > In Linux we do (rp->name == NULL), or even better yet (!rp->name), > please fix that up here and elsewhere in the driver. > I can fix that. I did that because checkpatch does not complain about it. also it avoids common mistake as: rp->name = NULL
> > + > > +#define PRIMITIVE_INFO_INIT(p, m, s, i, u, f) {#p, m, s, i, u, p, > > f} > > C has named initializers, use them please. > this macro can save lots of repeated text.
> greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe > platform-driver-x86" in the body of a message to > majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html
[Jacob Pan]
-- Thanks,
Jacob
| |