Messages in this thread Patch in this message | | | Date | Mon, 08 Apr 2013 11:48:27 +0800 | From | Chen Gang <> | Subject | [PATCH] kernel: events: strncpy, always be sure of NUL terminated. |
| |
for NUL terminated string, always be sure of '\0' at the end.
in our case, need return value, so still use strncpy (strlcpy return the size, not the pointer)
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- kernel/events/core.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 4757941..bdc0e25 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -4752,7 +4752,8 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) } else { if (arch_vma_name(mmap_event->vma)) { name = strncpy(tmp, arch_vma_name(mmap_event->vma), - sizeof(tmp)); + sizeof(tmp) - 1); + tmp[sizeof(tmp) - 1] = '\0'; goto got_name; } -- 1.7.7.6
| |