Messages in this thread Patch in this message | | | From | Richard Weinberger <> | Subject | [PATCH v2 1/2] efivars: Check max_size only if it is non-zero. | Date | Mon, 8 Apr 2013 00:32:17 +0200 |
| |
Some EFI implementations return always a MaximumVariableSize of 0, check against max_size only if it is non-zero.
Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/firmware/efivars.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 7acafb8..60c9899 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -449,7 +449,11 @@ check_var_size_locked(struct efivars *efivars, u32 attributes, if (status != EFI_SUCCESS) return status; - if (!storage_size || size > remaining_size || size > max_size || + if (!max_size && remaining_size > size) + printk_once(KERN_ERR FW_BUG "Broken EFI implementation is returning MaxVariableSize=0\n"); + + if (!storage_size || size > remaining_size || + (max_size && size > max_size) || (remaining_size - size) < (storage_size / 2)) return EFI_OUT_OF_RESOURCES; -- 1.8.1.4
| |