lkml.org 
[lkml]   [2013]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>
On Wed, 27 Mar 2013, Kent Overstreet wrote:

> Nope - looks like __WARN() doesn't exist if CONFIG_BUG=n, whoops.
>
> Adding this to the queue:
>
> commit 796c213186b850b3e6e8d5fd5799b0fd74721ea3
> Author: Kent Overstreet <koverstreet@google.com>
> Date: Wed Mar 27 12:47:45 2013 -0700
>
> bcache: Use WARN_ONCE() instead of __WARN()
>
> Signed-off-by: Kent Overstreet <koverstreet@google.com>
>
> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> index d4f2164..cb4578a 100644
> --- a/drivers/md/bcache/bset.c
> +++ b/drivers/md/bcache/bset.c
> @@ -883,7 +883,7 @@ struct bkey *bch_btree_iter_next(struct btree_iter *iter)
> iter->data->k = bkey_next(iter->data->k);
>
> if (iter->data->k > iter->data->end) {
> - __WARN();
> + WARN_ONCE(1, "bset was corrupt!\n");
> iter->data->k = iter->data->end;
> }
>

This problem still persists in linux-next as of today, how is this fix
being pushed?


\
 
 \ /
  Last update: 2013-04-07 23:41    [W:0.063 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site