Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [char-misc-next] mei: add debugfs hooks | Date | Fri, 5 Apr 2013 14:15:02 +0200 |
| |
On Friday 05 April 2013, Tomas Winkler wrote: > debugfs exposes device state and list of me clients and their > properties > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Just one small comment:
> +#define DEBUGFS_ADD_FILE(_mei, name, parent, mode) \ > + debugfs_create_file(#name, mode, parent, \ > + _mei, &mei_dbgfs_fops_##name)
This macro seems to obfuscate more than it helps. In general, string concatenation in macros is problematic because it means you can no longer grep for where a symbols is being used.
Arnd
| |