lkml.org 
[lkml]   [2013]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [char-misc-next] mei: add debugfs hooks
Date

> On Friday 05 April 2013, Tomas Winkler wrote:
> > debugfs exposes device state and list of me clients and their
> > properties
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Just one small comment:
>
> > +#define DEBUGFS_ADD_FILE(_mei, name, parent, mode) \
> > + debugfs_create_file(#name, mode, parent, \
> > + _mei, &mei_dbgfs_fops_##name)
>
>
> This macro seems to obfuscate more than it helps. In general, string
> concatenation in macros is problematic because it means you can no longer
> grep for where a symbols is being used.
>
This is very common shortcut mostly used in wireless drivers,
vut I don't mind to open code this, I will resubmit version two, this patch also needs a fix in the Makefile

Thanks
Tomas



\
 
 \ /
  Last update: 2013-04-05 15:21    [W:0.038 / U:1.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site