Messages in this thread | | | Date | Thu, 4 Apr 2013 09:55:16 +0200 | Subject | Re: [PATCH v2] i2c-hid: fix length for set/get report in i2c hid | From | Benjamin Tissoires <> |
| |
On Thu, Apr 4, 2013 at 9:47 AM, Jiri Kosina <jkosina@suse.cz> wrote: > On Wed, 3 Apr 2013, Huzefa Kankroliwala wrote: > >> With the current i2c hid driver set/get report does not work >> as expected, for e.g sensor hub properties like power state, >> frequency etc is not set properly on the device as a result >> we do not get events. >> The problem is that i2c hid driver in function i2c_hid_request >> sets length equal to default buffer size for which the sensor >> hub does not respond on get/set commands. Use report length >> and calculate it based on report size and id. >> >> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> >> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> >> Signed-off-by: Huzefa Kankroliwala <huzefa.nomanx.kankroliwala@intel.com> > > This is based on some old version of the driver though. Could you please > rebase it so that it applies on top of for-next branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git > > and resend? (actually rebasing on Linus' current tree would be absolutely > sufficient).
Actually, the patch goes smoothly on your for-next branch on my computer... And there is no point rebasing it on top of Linus' tree as the i2c_hid_request() callback is scheduled for 3.10.
Could you double check Jiri?
Thanks, Benjamin
> > Thanks. > > -- > Jiri Kosina > SUSE Labs
| |