lkml.org 
[lkml]   [2013]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] i2c-hid: fix length for set/get report in i2c hid
On Wed, 3 Apr 2013, Huzefa Kankroliwala wrote:

> With the current i2c hid driver set/get report does not work
> as expected, for e.g sensor hub properties like power state,
> frequency etc is not set properly on the device as a result
> we do not get events.
> The problem is that i2c hid driver in function i2c_hid_request
> sets length equal to default buffer size for which the sensor
> hub does not respond on get/set commands. Use report length
> and calculate it based on report size and id.
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Huzefa Kankroliwala <huzefa.nomanx.kankroliwala@intel.com>

This is based on some old version of the driver though. Could you please
rebase it so that it applies on top of for-next branch of

git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git

and resend? (actually rebasing on Linus' current tree would be absolutely
sufficient).

Thanks.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2013-04-04 10:21    [W:0.036 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site