Messages in this thread | | | Date | Thu, 4 Apr 2013 19:54:45 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 2/4] uprobes/tracing: Kill the pointless seq_print_ip_sym() call |
| |
* Oleg Nesterov <oleg@redhat.com> [2013-03-29 19:15:43]:
> seq_print_ip_sym(ip) in print_uprobe_event() is pointless, > kallsyms_lookup(ip) can not resolve a user-space address. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> --- > kernel/trace/trace_uprobe.c | 8 +------- > 1 files changed, 1 insertions(+), 7 deletions(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index af5b773..8e00901 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -531,13 +531,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e > field = (struct uprobe_trace_entry_head *)iter->ent; > tu = container_of(event, struct trace_uprobe, call.event); > > - if (!trace_seq_printf(s, "%s: (", tu->call.name)) > - goto partial; > - > - if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET)) > - goto partial; > - > - if (!trace_seq_puts(s, ")")) > + if (!trace_seq_printf(s, "%s: (0x%lx)", tu->call.name, field->ip)) > goto partial; > > data = (u8 *)&field[1]; > -- > 1.5.5.1 >
-- Thanks and Regards Srikar Dronamraju
| |