Messages in this thread | | | Date | Fri, 5 Apr 2013 17:01:10 +0200 | From | Oleg Nesterov <> | Subject | Re: Re: [PATCH 3/4] uprobes/tracing: Kill the pointless local_save_flags/preempt_count calls |
| |
On 04/05, Masami Hiramatsu wrote: > > Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks!
Masami, perhaps you can also answer the question I asked in 0/4 marc.info/?l=linux-kernel&m=136458107403835 ?
Off-topic question... Why uprobe_perf_func() passes "addr = ip" to perf_trace_buf_submit() ? This just sets perf_sample_data->addr for PERF_SAMPLE_ADDR, do we really need this? and we already have perf_sample_data->ip initialized by perf.
kprobe_perf_func() and kretprobe_perf_func() do the same.
Once again, I am just curious and this is completely offtopic.
Oleg.
| |