Messages in this thread Patch in this message | | | Date | Thu, 4 Apr 2013 14:17:09 +0800 | Subject | [PATCH -next] drbd: fix error return code in drbd_init() | From | Wei Yongjun <> |
| |
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> --- drivers/block/drbd/drbd_main.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 1b93a726..768bca9 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -2777,6 +2777,7 @@ int __init drbd_init(void) drbd_proc = proc_create_data("drbd", S_IFREG | S_IRUGO , NULL, &drbd_proc_fops, NULL); if (!drbd_proc) { printk(KERN_ERR "drbd: unable to register proc file\n"); + err = -ENOMEM; goto fail; } @@ -2786,6 +2787,7 @@ int __init drbd_init(void) retry.wq = create_singlethread_workqueue("drbd-reissue"); if (!retry.wq) { printk(KERN_ERR "drbd: unable to create retry workqueue\n"); + err = -ENOMEM; goto fail; } INIT_WORK(&retry.worker, do_retry);
| |