Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | posix_cpu_timer: initialize "now" variable | Date | Thu, 4 Apr 2013 13:45:41 +0000 |
| |
Patch 6d0e025 "posix_cpu_timer: consolidate expiry time type" in linux-next introduces a new compiler warning:
kernel/posix-cpu-timers.c: In function 'posix_cpu_timer_schedule': kernel/posix-cpu-timers.c:1127:19: warning: 'now' may be used uninitialized in this function [-Wmaybe-uninitialized] clear_dead_task(timer, now);
As far as I can tell, that warning is about an actual bug an not a false positive, as that variable is clearly never initialized when it gets used in line 1127.
Here is a patch that makes the warning go away for me, no idea if this is the right solution or not.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c index e5286b5..1828b9f 100644 --- a/kernel/posix-cpu-timers.c +++ b/kernel/posix-cpu-timers.c @@ -1119,6 +1119,7 @@ void posix_cpu_timer_schedule(struct k_itimer *timer) timer->it.cpu.expires = 0; goto out_unlock; } else if (unlikely(p->exit_state) && thread_group_empty(p)) { + cpu_clock_sample(timer->it_clock, p, &now); /* * We've noticed that the thread is dead, but * not yet reaped. Take this opportunity to
| |