lkml.org 
[lkml]   [2013]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error
From
On Fri, Mar 29, 2013 at 10:03 AM, Richard Genoud
<richard.genoud@gmail.com> wrote:

> As Stephen Warren pointed out, pinctrl_free_setting() was called instead
> of pinmux_disable_setting() on error.
> In this error code, we want to call pinmux_disable_setting() where
> pinmux_enable_setting() was called.
> And when pinconf_apply_setting() was called, we can't do much to undo
> the pin muxing (the closest thing I can think about for "unmuxing" a pin
> is muxing it as GPIO input).
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> This commit is on top of:
> [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error

Patch applied with Stephen's Review tag.

Thanks,
Linus Walleij


\
 
 \ /
  Last update: 2013-04-03 21:24    [W:0.062 / U:4.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site