Messages in this thread | | | Date | Wed, 3 Apr 2013 14:37:40 +0200 | Subject | Re: [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error | From | Linus Walleij <> |
| |
On Fri, Mar 29, 2013 at 10:03 AM, Richard Genoud <richard.genoud@gmail.com> wrote:
> As Stephen Warren pointed out, pinctrl_free_setting() was called instead > of pinmux_disable_setting() on error. > In this error code, we want to call pinmux_disable_setting() where > pinmux_enable_setting() was called. > And when pinconf_apply_setting() was called, we can't do much to undo > the pin muxing (the closest thing I can think about for "unmuxing" a pin > is muxing it as GPIO input). > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com> > --- > This commit is on top of: > [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error
Patch applied with Stephen's Review tag.
Thanks, Linus Walleij
| |