Messages in this thread | | | Date | Fri, 29 Mar 2013 10:09:16 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error |
| |
On 03/29/2013 03:03 AM, Richard Genoud wrote: > As Stephen Warren pointed out, pinctrl_free_setting() was called instead > of pinmux_disable_setting() on error. > In this error code, we want to call pinmux_disable_setting() where > pinmux_enable_setting() was called.
> And when pinconf_apply_setting() was called, we can't do much to undo > the pin muxing (the closest thing I can think about for "unmuxing" a pin > is muxing it as GPIO input).
That's likely typically what pinmux_disable_setting() does, or perhaps it'll select a function for that pin/group that is guaranteed not to conflict with any possible other mux configuration.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
| |