lkml.org 
[lkml]   [2013]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Basic perf PMU support for Haswell v11

* Ingo Molnar <mingo@kernel.org> wrote:

> You say it's barebones, yet it does not work :-( How well was this
> patch-set tested on non-Haswell hardware, which makes up 99.99% of our
> installed base?
>
> In particular, after applying your patches, 'perf top' stopped working
> on an Intel testbox of mine:

The other problem I noticed was stylistic: when I applied your patches for
testing even Git complained about their cleanliness ...

To quote from Documentation/SubmittingPatches:

4) Style check your changes.

Check your patch for basic style violations, details of which can be
found in Documentation/CodingStyle. Failure to do so simply wastes
the reviewers time and will get your patch rejected, probably
without even being read.

At a minimum you should check your patches with the patch style
checker prior to submission (scripts/checkpatch.pl). You should
be able to justify all violations that remain in your patch.

Please make your patches less sloppy!

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-04-26 09:21    [W:0.207 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site