Messages in this thread | | | Date | Fri, 26 Apr 2013 18:18:09 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 03/26] perf tools: Move arch check into config/Makefile |
| |
On Fri, Apr 26, 2013 at 01:37:09PM +0200, Jiri Olsa wrote: > On Thu, Apr 25, 2013 at 06:15:52PM +0900, Namhyung Kim wrote: > > On Wed, 24 Apr 2013 11:37:30 +0200, Jiri Olsa wrote: > > > Moving arch check into config/Makefile. > > > > > [SNIP] > > > +# include config/Makefile by default and rule out > > > +# non-config cases > > > +config := 1 > > > + > > > +# standalone clean > > > +ifeq ($(MAKECMDGOALS),clean) > > > + config := 0 > > > endif > > > -ifeq ($(ARCH),x86_64) > > > - override ARCH := x86 > > > - IS_X86_64 := 0 > > > - ifeq (, $(findstring m32,$(EXTRA_CFLAGS))) > > > - IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -x c - | tail -n 1) > > > - endif > > > - ifeq (${IS_X86_64}, 1) > > > - RAW_ARCH := x86_64 > > > - ARCH_CFLAGS := -DARCH_X86_64 > > > - ARCH_INCLUDE = ../../arch/x86/lib/memcpy_64.S ../../arch/x86/lib/memset_64.S > > > - endif > > > - NO_PERF_REGS := 0 > > > - LIBUNWIND_LIBS = -lunwind -lunwind-x86_64 > > > + > > > +# tags cscope > > > +ifneq ($(filter tags cscope,$(MAKECMDGOALS)),) > > > + config := 0 > > > +endif > > > > Good idea! > > > > How about consolidating them like: > > > > NON_CONFIG_TARGETS := clean TAGS tags cscope help > > > > ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),) > > config := 0 > > endif > > nice, I'll do that > > thanks, > jirka
Namhyung, if you'd like to check, all changes addressing your comments are in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/core_make
I'll wait a bit for other comments and resend the patchset later
thanks, jirka
| |