Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 03/26] perf tools: Move arch check into config/Makefile | Date | Thu, 25 Apr 2013 18:15:52 +0900 |
| |
On Wed, 24 Apr 2013 11:37:30 +0200, Jiri Olsa wrote: > Moving arch check into config/Makefile. > [SNIP] > +# include config/Makefile by default and rule out > +# non-config cases > +config := 1 > + > +# standalone clean > +ifeq ($(MAKECMDGOALS),clean) > + config := 0 > endif > -ifeq ($(ARCH),x86_64) > - override ARCH := x86 > - IS_X86_64 := 0 > - ifeq (, $(findstring m32,$(EXTRA_CFLAGS))) > - IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -x c - | tail -n 1) > - endif > - ifeq (${IS_X86_64}, 1) > - RAW_ARCH := x86_64 > - ARCH_CFLAGS := -DARCH_X86_64 > - ARCH_INCLUDE = ../../arch/x86/lib/memcpy_64.S ../../arch/x86/lib/memset_64.S > - endif > - NO_PERF_REGS := 0 > - LIBUNWIND_LIBS = -lunwind -lunwind-x86_64 > + > +# tags cscope > +ifneq ($(filter tags cscope,$(MAKECMDGOALS)),) > + config := 0 > +endif
Good idea!
How about consolidating them like:
NON_CONFIG_TARGETS := clean TAGS tags cscope help
ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),) config := 0 endif
This way, we can handle multiple targets properly IMHO.
$ make clean all $ make clean tags
Thanks, Namhyung
> + > +ifeq ($(config),1) > +include config/Makefile > endif
| |