Messages in this thread | | | Date | Fri, 26 Apr 2013 12:19:08 +0200 | From | Fabio Baltieri <> | Subject | Re: [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL() |
| |
On Thu, Apr 25, 2013 at 06:46:35PM +0100, Russell King wrote: > On Thu, Apr 25, 2013 at 10:13:34AM -0400, Eduardo Valentin wrote: > > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c > > index 21419851..786d192 100644 > > --- a/drivers/thermal/db8500_cpufreq_cooling.c > > +++ b/drivers/thermal/db8500_cpufreq_cooling.c > > @@ -37,7 +37,7 @@ static int db8500_cpufreq_cooling_probe(struct platform_device *pdev) > > cpumask_set_cpu(0, &mask_val); > > cdev = cpufreq_cooling_register(&mask_val); > > > > - if (IS_ERR_OR_NULL(cdev)) { > > + if (IS_ERR(cdev)) { > > dev_err(&pdev->dev, "Failed to register cooling device\n"); > > return PTR_ERR(cdev); > > Correct. cpufreq_cooling_register() returns either an error-pointer or > a valid pointer.
Acked-by: Fabio Baltieri <fabio.baltieri@linaro.org>
...but more of these are going to appear forever, was the proposed removal of IS_ERR_OR_NULL rejected? Can't find any new message about that on the list.
Fabio
-- Fabio Baltieri
| |