Messages in this thread | | | Date | Thu, 25 Apr 2013 18:46:35 +0100 | From | Russell King <> | Subject | Re: [PATCH 2/2] thermal: db8500_cpufreq_cooling: remove usage of IS_ERR_OR_NULL() |
| |
On Thu, Apr 25, 2013 at 10:13:34AM -0400, Eduardo Valentin wrote: > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c b/drivers/thermal/db8500_cpufreq_cooling.c > index 21419851..786d192 100644 > --- a/drivers/thermal/db8500_cpufreq_cooling.c > +++ b/drivers/thermal/db8500_cpufreq_cooling.c > @@ -37,7 +37,7 @@ static int db8500_cpufreq_cooling_probe(struct platform_device *pdev) > cpumask_set_cpu(0, &mask_val); > cdev = cpufreq_cooling_register(&mask_val); > > - if (IS_ERR_OR_NULL(cdev)) { > + if (IS_ERR(cdev)) { > dev_err(&pdev->dev, "Failed to register cooling device\n"); > return PTR_ERR(cdev);
Correct. cpufreq_cooling_register() returns either an error-pointer or a valid pointer.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
| |