Messages in this thread | | | Date | Wed, 24 Apr 2013 14:24:20 +0300 | Subject | Re: [PATCH] x86_32: Fix module version table mismatch. | From | Andy Shevchenko <> |
| |
On Wed, Apr 24, 2013 at 1:13 PM, James Hogan <james.hogan@imgtec.com> wrote: > On 24/04/13 02:00, H. Peter Anvin wrote: >> On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
>> Either way -- James, Rusty, this is in your court. > > How does the patch below look? I presume this is preferred over > making VMLINUX_SYMBOL_STR non-argument-expanding?
I will test it soon.
> Subject: [PATCH 1/1] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion > > Commit a4b6a77b77ba4f526392612c2365797fab956014 ("module: fix symbol > versioning with symbol prefixes") broke the MODVERSIONS loading of any > module using memcmp (e.g. ipv6) on x86_32, as it's defined to > __builtin_memcmp which is expanded by VMLINUX_SYMBOL_STR. Use > __VMLINUX_SYMBOL_STR instead which doesn't expand the argument. > > Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To be strongly correct Tetsuo and me reported about it and Tetsuo did first analysis.
> Signed-off-by: James Hogan <james.hogan@imgtec.com> > Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-- With Best Regards, Andy Shevchenko
| |