Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH v2] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion | Date | Mon, 29 Apr 2013 11:40:19 +0930 |
| |
James Hogan <james.hogan@imgtec.com> writes: > Commit a4b6a77b77ba4f526392612c2365797fab956014 ("module: fix symbol > versioning with symbol prefixes") broke the MODVERSIONS loading of any > module using memcmp (e.g. ipv6) on x86_32, as it's defined to > __builtin_memcmp which is expanded by VMLINUX_SYMBOL_STR. Use > __VMLINUX_SYMBOL_STR instead which doesn't expand the argument. > > Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: James Hogan <james.hogan@imgtec.com> > Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: H. Peter Anvin <hpa@zytor.com> > Tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > > I've corrected commit message tags for Rusty's convenience. > Updated Reported-by to include Andy > Taken the liberty of adding Tetsuo's Tested-by
Applied.
Thanks especially for chasing this: I was away for a few days last week.
Cheers, Rusty.
| |