Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 12/21] mmc: sdhci-tegra: fix MODULE_DEVICE_TABLE | Date | Tue, 23 Apr 2013 20:55:32 +0200 |
| |
The symbol referenced in MODULE_DEVICE_TABLE must match the actual table, otherwise we get a build error like
sdhci-tegra.c:206:34: error: '__mod_of_device_table' aliased to undefined symbol 'sdhci_dt_ids'
Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Stephen Warren <swarren@nvidia.com> Cc: Chris Ball <cjb@laptop.org> --- On Tuesday 23 April 2013, Chris Ball wrote:
> I was going to take this, but it doesn't apply to mmc-next or > linux-next, because the #endif in your first line of context isn't > present in those trees -- which tree is this based on?
I based it on 3.9-rc8.
> Sounds like it might make more sense for you to take this; if so: > Acked-by: Chris Ball <cjb@laptop.org>
This is the rebased version on linux-next. I think it's better if you take it, otherwise we just create a merge conflict for Linus.
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 45048d1..e0dba74 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -203,7 +203,7 @@ static const struct of_device_id sdhci_tegra_dt_match[] = { { .compatible = "nvidia,tegra20-sdhci", .data = &soc_data_tegra20 }, {} }; -MODULE_DEVICE_TABLE(of, sdhci_dt_ids); +MODULE_DEVICE_TABLE(of, sdhci_tegra_dt_match); static void sdhci_tegra_parse_dt(struct device *dev) {
| |