lkml.org 
[lkml]   [2013]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 14/21] staging: nvec: allow modular build
    Date
    On Tuesday 23 April 2013 21:41:03 Arnd Bergmann wrote:
    > On Tuesday 23 April 2013, Marc Dietrich wrote:
    > > On Tuesday 23 April 2013 18:30:46 Arnd Bergmann wrote:
    > > > The serio code can be a loadable module, which in turn means that nvec
    > > > also has to be a module, so mark it as "tristate" in Kconfig.
    > >
    > > oh, I didn't saw this randconfig error posting. NVEC isn't prepared for
    > > modularized builds yet (it's on the TODO list though). So better say
    > > SERIO=y here. Looking a bit closer, there is other stuff which can also
    > > be a module (GPIOLIB, I2C, ...) so these also need a =y.
    >
    > What is the problem with building it as a module? It looks all fine in that
    > regard.

    It builds, but I haven't tried out it yet. At least the mfd children need to
    unregister the event notifier I guess. Anyway, I have no time to test this
    now, so I prefer to force =y for the dependencies for now.

    > I also did not see any problems with the other symbols, but that may be
    > because they get turned on as built-in even in allmodconfig. Marking it
    > as tristate certainly avoids the problem altogether.
    >
    > > Should a post a patch?
    >
    > If you have follow-on patches, they need to go on top now, since Greg
    > already took this patch.

    arrr, I wonder why Greg thought that a 4 minute review time is enough :-(
    I'll try to post a patch tomorrow then.

    Marc



    \
     
     \ /
      Last update: 2013-04-23 22:21    [W:4.163 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site