Messages in this thread | | | Date | Mon, 22 Apr 2013 17:22:18 +0300 | From | Dan Carpenter <> | Subject | Re: [BUG] staging: android: ashmem: Deadlock during ashmem_shrink |
| |
Read Al's email again: https://lkml.org/lkml/2013/3/20/458
I don't know much about VFS locking, but the ashmem locking seems pretty bogus to me. Why can't multiple threads read() at the same time?
One thing is that it should probably be broken into different locks instead of a mini-BKL. Instead of taking a bad design and trying to hack it until it doesn't crash I think it would be better to redo the locking from scratch.
regards, dan carpenter
| |