Messages in this thread | | | Subject | memcpy_fromio in dmi_scan.c | From | Jean Delvare <> | Date | Mon, 22 Apr 2013 15:18:09 +0200 |
| |
Hi Duan, Andrew,
I am looking at the following commit:
commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 Author: Zhenzhong Duan <zhenzhong.duan@oracle.com> Date: Thu Dec 20 15:05:14 2012 -0800
drivers/firmware/dmi_scan.c: fetch dmi version from SMBIOS if it exists
And I am worried about calls to memcpy_fromio(), or lack thereof. Before this commit, the code would take great care to always call memcpy_fromio() to get data from the 0xF0000-0xFFFFF memory range (BIOS data) and operate on that copy. After this commit, the code is happily calling memcmp() directly on an __iomem pointer. It seems to be harmless on x86, but it will break on IA64, won't it?
-- Jean Delvare Suse L3
| |