Messages in this thread | | | Date | Thu, 18 Apr 2013 20:48:15 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 12/12] radio-si476x: Fix incorrect pointer checking |
| |
On Thu, Apr 18, 2013 at 09:58:38AM -0700, Andrey Smirnov wrote: > Fix incorrect pointer checking and make some minor code improvements: > > * Remove unnecessary elements from function pointer table(vtable), > that includes all the elements that are FM-only, this allows for not > checking of the fucntion pointer and calling of the function > directly(THe check if the tuner is in FM mode has to be done anyway) > > * Fix incorrect function pointer checking where the code would check one > pointer to be non-NULL, but would use other pointer, which would not > be checked. > > * Remove code duplication in "si476x_radio_read_rsq_blob" and > "si476x_radio_read_rsq_primary_blob". > > * Add some BUG_ON statements for function pointers that should never be NULL > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This should be a Reported-by for me, probably.
regards, dan carpenter
| |