lkml.org 
[lkml]   [2013]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC
On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Provide some trace, though the hardware is most likely non-functional if
> this happens.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/leds/leds-wm8350.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c
> index ed15157..86bdab3 100644
> --- a/drivers/leds/leds-wm8350.c
> +++ b/drivers/leds/leds-wm8350.c
> @@ -129,7 +129,11 @@ static void wm8350_led_disable(struct wm8350_led *led)
> ret = regulator_disable(led->isink);
> if (ret != 0) {
> dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
> - regulator_enable(led->dcdc);
> + ret = regulator_enable(led->dcdc);
> + if (ret != 0) {
looks like we don't need this bracket here.

> + dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
> + ret);
> + }
ditto.

Thanks,
-Bryan


\
 
 \ /
  Last update: 2013-03-05 20:42    [W:0.068 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site