lkml.org 
[lkml]   [2013]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC
On Tue, Mar 05, 2013 at 11:03:52AM -0800, Bryan Wu wrote:
> On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown

> > if (ret != 0) {
> > dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
> > - regulator_enable(led->dcdc);
> > + ret = regulator_enable(led->dcdc);
> > + if (ret != 0) {
> looks like we don't need this bracket here.
>
> > + dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
> > + ret);
> > + }
> ditto.

It's not required but since it's inside a small but multi-line block
there's the whole thing about including braces at all levels for
clarity.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-03-06 06:42    [W:0.601 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site